Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Arrows to navigate search results while in a document (supersedes #3676) #3807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

panglesd
Copy link
Contributor

Supersedes #3676 with a branch in c2c_ui to be able to run the CI and deploy a preview.

Copy-pasted first post, but there were some answers on the initial PR that I don't copy paste.

This is an attempt to fix #3612.

When relevant, list of documents are attached a search_query field, containing the query that got them, with bounds centered on them.

Then, when a document is displayed, we are able to get "previous" and "next" documents and generate arrow buttons. We can also generate a list of results "a search navigation box".

A screenshot:
image

Questions/warnings/things to improve:

  • I will need some help with the visual design!
  • When visiting a waypoint, we can click on an associated route and the "associated search" will be the one for all routes associated to this one. BUT: the routes are ordered alphabetically, which is not possible in search queries.
  • Similarly, when visiting a waypoint and clicking on an associated route, the search query associated is for all activities. We could restrict it to the activity that was clicked.

Let me know what you think! In my opinion it is very useful to navigate a set of documents using arrows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : add arrow buttons at the bottom and top of outings and routes documents to easier navigation
1 participant