-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: c2corg#2313 api climbing error translation #3873
base: master
Are you sure you want to change the base?
fix: c2corg#2313 api climbing error translation #3873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
the i18n system we use is a bit more complex than this, sorry 🙁
First, keys are automatically extracted from the code, as described here: https://github.com/c2corg/c2c_ui/wiki/i18n, and then hanled through the transifex online tool. What should be done here, because the key cannot be inferred from the code, is to add an hint to the tool (simiar to what has been done in src\views\wiki\edition\utils\document-edition-view-mixin.js
, but e.g. in the association tool). The translations will then be updated on transifex (you could request access if you wish) and PR generated automatically through a github action.
3766e64
to
0fac6c2
Compare
HI ! Since this error will be raised by the API when saving the document, the message is handled by
Are you thinking about displaying this error when an climbing indoor waypoint is selected by the association tool ? c2c_ui/src/js/vue-plugins/document-utils.js Line 161 in 34b99b5
Wouldn't be the best to not display at all this kind of waypoint in the input suggestions ? |
Indeed.
This should be the case already, but you never know :) |
No description provided.