Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: c2corg#2313 api climbing error translation #3873

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nayor
Copy link
Contributor

@Nayor Nayor commented Mar 8, 2024

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Mar 8, 2024
Copy link
Member

@brunobesson brunobesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

the i18n system we use is a bit more complex than this, sorry 🙁

First, keys are automatically extracted from the code, as described here: https://github.com/c2corg/c2c_ui/wiki/i18n, and then hanled through the transifex online tool. What should be done here, because the key cannot be inferred from the code, is to add an hint to the tool (simiar to what has been done in src\views\wiki\edition\utils\document-edition-view-mixin.js, but e.g. in the association tool). The translations will then be updated on transifex (you could request access if you wish) and PR generated automatically through a github action.

@Nayor Nayor force-pushed the fix/#2313-api-climbing-error-translation branch from 3766e64 to 0fac6c2 Compare March 11, 2024 13:19
@Nayor
Copy link
Contributor Author

Nayor commented Mar 11, 2024

HI !

Since this error will be raised by the API when saving the document, the message is handled by src\views\wiki\edition\utils\document-edition-view-mixin.js right ?

Are you thinking about displaying this error when an climbing indoor waypoint is selected by the association tool ?

addAssociation(document, child) {

Wouldn't be the best to not display at all this kind of waypoint in the input suggestions ?

@brunobesson
Copy link
Member

Are you thinking about displaying this error when an climbing indoor waypoint is selected by the association tool ?

Indeed.

Wouldn't be the best to not display at all this kind of waypoint in the input suggestions ?

This should be the case already, but you never know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants