Display total count instead of percent and order by count #123
Conversation
| return { Candidate: select.Choices[index], Percentage: `${percent}%` }; | ||
| }); | ||
| res = countSelectResult(selectResult.get(id)) | ||
| .map(([, totalCount], index) => { |
There was a problem hiding this comment.
The linter doesn't complain? I thought you'd have to write .map(([_, totalCount] here.
There was a problem hiding this comment.
no, the linter is quite happy like that and actually made me change it to this 🤷♀️
| return { | ||
| Candidate: select.Choices[index], | ||
| TotalCount: totalCount, | ||
| NumberOfBallots: selectResult.get(id).length, |
There was a problem hiding this comment.
Question: what is NumberOfBallots here?
- the total ballots cast (including multi ballot cast)
- the total number of voters (with multi ballot cast removed)
- the total number of valid ballots (with multi ballot and invalid ballots removed)
I think both 2 and 3 are OK, but it should be mentioned somewhere on the page which it is.
There was a problem hiding this comment.
it's the number of valid ballots for the 'select' type of form as send back by the server
| max = current; | ||
| } | ||
| return current; | ||
| let results: [string, number][] = []; |
There was a problem hiding this comment.
| let results: [string, number][] = []; | |
| const results: [string, number][] = []; |
push and pop are allowed on const. But this makes sure that you don't re-assign it a different array.
| selectResult | ||
| .reduce( | ||
| (tally, currBallot) => tally.map((currCount, index) => currCount + currBallot[index]), | ||
| new Array(selectResult[0].length).fill(0) | ||
| ) | ||
| .forEach((totalCount) => { | ||
| results.push([ | ||
| (Math.round((totalCount / selectResult.length) * 100 * 100) / 100).toFixed(2).toString(), | ||
| totalCount, | ||
| ]); |
There was a problem hiding this comment.
Or remove the let result altogether and do something like:
| selectResult | |
| .reduce( | |
| (tally, currBallot) => tally.map((currCount, index) => currCount + currBallot[index]), | |
| new Array(selectResult[0].length).fill(0) | |
| ) | |
| .forEach((totalCount) => { | |
| results.push([ | |
| (Math.round((totalCount / selectResult.length) * 100 * 100) / 100).toFixed(2).toString(), | |
| totalCount, | |
| ]); | |
| return selectResult | |
| .reduce( | |
| (tally, currBallot) => tally.map((currCount, index) => currCount + currBallot[index]), | |
| new Array(selectResult[0].length).fill(0) | |
| ) | |
| .map((totalCount) => | |
| [ | |
| (Math.round((totalCount / selectResult.length) * 100 * 100) / 100).toFixed(2).toString(), | |
| totalCount, | |
| ]); |
| "Title": { | ||
| "En": "CMYK", | ||
| "Fr": "CMJN", | ||
| "De": "CMYK" |
There was a problem hiding this comment.
Joke: Wir haben keine Übersetzung dafür? Sowas... "CMGS"?
There was a problem hiding this comment.
https://www.din.de/de/wdc-beuth:din21:5463877
jedenfalls nicht in Deutschland 🤷♀️
Display election results as total count instead of percent and order by count. Adds tests for the results.
Closes #45