Add interpolation when reading setup.cfg. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4urself
requested changes
Aug 24, 2018
bumpversion/__init__.py
Outdated
| @@ -3,9 +3,9 @@ | |||
| from __future__ import unicode_literals | |||
|
|
|||
| try: | |||
| from configparser import RawConfigParser, NoOptionError | |||
| from configparser import RawConfigParser, ConfigParser, NoOptionError | |||
There was a problem hiding this comment.
can we add a comment at the end here: # py3
There was a problem hiding this comment.
Can I make it a bit more descriptive than just # py3, do you want this for some sort of linter?
There was a problem hiding this comment.
Sure -- not for a linter but for my own sanity of jumping back and forth between the two...
c4urself
approved these changes
Aug 29, 2018
|
@SethMMorton -- can you rebase to resolve the conflicts |
Setuptools uses the default ConfigParser object when reading setup.cfg which does interpolation. To be consistent with that format bumpversion must do the same. This will close issue c4urself#21.
Leaving things better than I found it :)
SethMMorton
force-pushed
the
correct-interpolation-in-setup-cfg
branch
from
0b180f2 to
e5688dc
Compare
|
Done ✅ |
|
thanks @SethMMorton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools uses the default ConfigParser object when reading
setup.cfg which does interpolation. To be consistent with that format
bumpversion must do the same.
Fixes #21.