Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: embed tzdata in binary #62

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: embed tzdata in binary #62

merged 1 commit into from
Oct 1, 2024

Conversation

jonathan-mayer
Copy link
Member

Motivation

Closes #61
The docker image size increase of ~500KB is negligible

Changes

Tests done

  • tested locally

TODO

@jonathan-mayer jonathan-mayer added the bug Something isn't working label Oct 1, 2024
@jonathan-mayer jonathan-mayer self-assigned this Oct 1, 2024
@github-actions github-actions bot added the needs approval This pull request needs additional approval label Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

⚠️ Warning: Merging this PR will result in a new release because the appVersion in Chart.yaml has changed to 1.1.1. Please confirm this by adding the new release label before merging.

@jonathan-mayer jonathan-mayer mentioned this pull request Oct 1, 2024
Closed
JTaeuber
JTaeuber approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JTaeuber JTaeuber added the new release This is a new release of the GoKubeDownscaler label Oct 1, 2024
@github-actions github-actions bot removed the needs approval This pull request needs additional approval label Oct 1, 2024
@JTaeuber JTaeuber merged commit 4fcf4ec into main Oct 1, 2024
7 of 9 checks passed
@JTaeuber JTaeuber deleted the fix/no-tzdata-in-docker-image branch October 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTaeuber JTaeuber JTaeuber approved these changes

@jon4skl jon4skl Awaiting requested review from jon4skl jon4skl is a code owner

Assignees

@jonathan-mayer jonathan-mayer

Labels
bug Something isn't working new release This is a new release of the GoKubeDownscaler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: failed to parse timezone
2 participants
@jonathan-mayer @JTaeuber