chore: minor fixes in docs, corrected questions.yaml #16
+3
−1,417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumel8
added a commit
that referenced
this pull request
Sep 21, 2023
* Fix/questions (#15) * fix: no namespace ALL are allowed in k8s-sidecar search * fix: no required namespaces in a single namespace installation * fix: pause feature only if it's enabled * bump chart version * fix: restore question, sub without effect * fix: retentionSize * chore: minor fixes in docs, corrected questions.yaml (#16) * bump 1.0.22 * fix: removed the unnecessary second grafana datasource * chore: bumped chart version * debug: remove datasource mgmt via sidecar * chore: finalized fix --------- Co-authored-by: Bruno Bressi <[email protected]> Co-authored-by: Bruno Bressi <[email protected]>
eumel8
added a commit
that referenced
this pull request
Sep 21, 2023
* add webex template and bump versions to kube-prometheus-spec 51.0.3 release * fix: no namespace ALL are allowed in k8s-sidecar search * fix: no required namespaces in a single namespace installation * fix: subquestions showing only if feature is enabled (won't work) * fix repositories prometheus/alertmanager * patch prometheus security resources (prepared) * fix registry * update k8s-sidecar image * Fix/remove duplicate datasource (#17) * Fix/questions (#15) * fix: no namespace ALL are allowed in k8s-sidecar search * fix: no required namespaces in a single namespace installation * fix: pause feature only if it's enabled * bump chart version * fix: restore question, sub without effect * fix: retentionSize * chore: minor fixes in docs, corrected questions.yaml (#16) * bump 1.0.22 * fix: removed the unnecessary second grafana datasource * chore: bumped chart version * debug: remove datasource mgmt via sidecar * chore: finalized fix --------- Co-authored-by: Bruno Bressi <[email protected]> Co-authored-by: Bruno Bressi <[email protected]> * fix securityContect Prometheus/Alertmanager * prepare patch job * fix patchjob values * fix values --------- Co-authored-by: Bruno Bressi <[email protected]> Co-authored-by: Bruno Bressi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One description in the questions.yaml had a not-exactly-correct description, as if the additional namespaces aren't provided, the service account cannot interact with the various prometheus-related resources in the projects namespaces.
Changes