Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart value): fixing interval from 60 to 30 as it's the default #109

Closed
wants to merge 1 commit into from

Conversation

cristian98149
Copy link

Motivation

From docs, default interval values is 30 but on chart values 60 is set.

@samuel-esp
Copy link
Collaborator

Oh we didn't noticed that, thanks for pointing it out. I think it would be better to change the default time to 60' inside the documentation. I don't see a strong reason to set the interval at 30' as the new default inside the deployment. I'll wait also for @jonathan-mayer @JTaeuber @Fovty opinions

@cristian98149
Copy link
Author

What's the interval used for?

It could impact time needed for scaling down workloads? I'm noticing that if workloads to scale are too much (almost 600) it takes long time to scale them.

Thank you

@JTaeuber
Copy link
Member

@samuel-esp I agree. It is probably better to just change the docs to the correct value.

@cristian98149 The interval is the time in between scans of the py-kube-downscaler. Meaning that every minute the py-kube-downscaler looks for workloads with the appropriate annotations and then scales them. If needed you can change the interval to 30 seconds in a custom values file afterwards.

@JTaeuber JTaeuber mentioned this pull request Nov 14, 2024
2 tasks
@jonathan-mayer
Copy link
Member

Closing this since it is going to be implemented in #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants