Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure configMapName Value is Used Consistently Across Templates #56

Merged
merged 1 commit into from
May 23, 2024

Conversation

Fovty
Copy link
Member

@Fovty Fovty commented May 23, 2024

Motivation

This change aims to address the issue where the configMapName key in the kube-downscaler Helm chart does not correctly set the name of the generated ConfigMap.

Changes

  • Updated templates/configmap.yaml to use the value of configMapName for the ConfigMap name.
  • No changes to templates/deployment.yaml - already using the value of configMapName.

Tests done

  • Rendered the Helm templates locally using helm template to verify that the configMapName value is correctly applied in the generated Kubernetes manifests.

TODO

  • I've assigned myself to this PR

@Fovty Fovty self-assigned this May 23, 2024
Copy link

File Coverage
All files 97%
test_autoscale_resource.py 99%
test_cmd.py 100%
test_events.py 100%
test_grace_period.py 100%
test_ignore_if_labels_dont_match.py 100%
test_main.py 100%
test_pods_force_uptime.py 100%
test_resources.py 100%
test_scaler.py 95%
test_time.py 100%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 8042c33

@Fovty Fovty added the enhancement New feature or request label May 23, 2024
@JTaeuber JTaeuber added the fix label May 23, 2024
@Fovty Fovty merged commit 336d48a into main May 23, 2024
5 checks passed
@Fovty Fovty deleted the fix/use-configMapName-value-in-template branch May 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants