Ensure configMapName Value is Used Consistently Across Templates #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change aims to address the issue where the
configMapName
key in the kube-downscaler Helm chart does not correctly set the name of the generated ConfigMap.configMapName
key in the Helm values.yaml file #55Changes
templates/configmap.yaml
to use the value ofconfigMapName
for the ConfigMap name.templates/deployment.yaml
- already using the value ofconfigMapName
.Tests done
helm template
to verify that theconfigMapName
value is correctly applied in the generated Kubernetes manifests.TODO