New Feature: New Downscaler/Grace-Period Annotation To Override Global Grace Period for Individual Resources #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-esp
requested review from
Fovty,
jonathan-mayer and
JTaeuber
as code owners
JTaeuber
pushed a commit
that referenced
this pull request
Jul 22, 2024
…l Grace Period for Individual Resources (#74) * added downscaler/grace-period annotation support * added grace period annotation unit tests * refactored documentations * refactored docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This feature introduces the ability to override the global grace period defined by the
--grace-periodargument in the main deployment. By using the newdownscaler/grace-periodannotation, you can set a specific grace period for individual resources.Important: The annotation will only override the global grace period if the value specified in the annotation is shorter than the globally defined grace period. This ensures that the feature cannot be misused by users to extend the grace period beyond the intended limit.
Changes
downscaler/grace-periodwithin_grace_periodandwithin_grace_period_namespacefunctions where refactored to implement the logic described aboveTests done
Unit tests inside
test_grace_period.pyTODO