Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: topic secondary index #20

Closed
wants to merge 1 commit into from
Closed

feat: topic secondary index #20

wants to merge 1 commit into from

Conversation

cablehead
Copy link
Owner

@cablehead cablehead commented Oct 28, 2024

Conflict resolved version of PR created by @marvin-j97 #19

  • Added secondary index partition for topics
  • Write to index in Store::append as well, using write batch
  • Index key uses topic + 0xFF + frame ID as encoding
  • Removed mut condition from Store::append
  • Use topic index in Store::head
  • Added basic head test
  • Change Store::head to only need topic as &str (no heap allocation)

@marvin-j97
Copy link
Collaborator

I think you squashed the commits

@cablehead
Copy link
Owner Author

Yeah. Or rather, I just ran through your full diff and made the changes again to main.. it was easier that way 😆

@cablehead cablehead closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants