This repository has been archived by the owner on Apr 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Changes in order to get it to compile for Microsoft windows compilers #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes were needed to get a built working under Microsoft Windows compilers/runtimes. * Change a couple of header files * Change the use of inline to be a windows keyword if using a windows compiler. * Create a definition for ssize_t in windows as this is a POSIX constructu
See previous comment.
Note: you should be able to generate visual studio files with cmake. Something like:
|
Your are making an assumption that I am on a system that has cmake. I am running on pure windows at the moment. However adding files to a new project is trivial so I just did not worry about it. |
This change does address Issue #26 for windows systems. |
Download cmake Win32 binaries here: http://www.cmake.org/download/ we could also checkin the outputs I suppose. |
Changes to get the cmake build system do the right thing on windows Start making changes to deal with the sizeof(int) != 8 problem
Add cmake file
I would like not to mix the 64-bit fixes (which are needed for all systems) with the fixes around lacking unistd.h etc. |
Merge to current
Delete #1 - emacs temp file
Fix merge problem
Still should do a rename of this macro to be more correct
Created a new pull request with just the header file changes. |
Conflicts: include/cn-cbor/cn-cbor.h src/cn-cbor.c src/cn-get.c
Does this help?
Missed some changes during the merge step
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of changes to get it to compile with Visual Studio. No Visual Studio solution files have been included, you will need to build your own.