Pier/feat-load-kb-csv #24
Conversation
(assumed to be correct)
and not a File
|
Awesome! Great news!! I'll check this out in a moment, but the green check on CI/CD is very motivating :) |
There was a problem hiding this comment.
@cad0p hey, this is great! Very well done, and happy to see that it works 👍 I'd be eager to approve, but seeing that this depends on the unmerged PRs, I'd suggest we either hold it off and merge after #22 or #23, or remove all the CLI-related stuff and keep the implementation only to the changes of LibCore. What do you think? Since you won't have much time tomorrow, up to you if you'd like to do it now, or wait till tomorrow.
| replaceMode [email protected]{} = do | ||
| case input c of | ||
| Nothing -> error "No input FilePath was found" | ||
| -- TODO from Pier to Wilmer: this error above is never reached |
There was a problem hiding this comment.
Even not if you supply no input file?
There was a problem hiding this comment.
Yes try, because it gets replaced with the default one
|
|
||
| -- | ShortHndr default KB | ||
| defaultKB :: String | ||
| defaultKB = "data/shorthndr-kb.csv" |
|
|
@wzwietering sure, I think that's a good idea to move forward with 👍 |
|
@wzwietering, I approved #22 👍 |
|
|
What
Loading KB from csv.
Issues
Right now it doesn't typecheck
Why
To get the KB to then return the expanded string using it.