downgrade minimum Go version #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
|
I've pushed v0.1.3 of the zerossl package which has the lower go version in go.mod; do we need to upgrade that dep in this PR? |
Yes. I'm mobile right now. If you can do it, go for it. Otherwise, it's just as upgrade of zersl then |
|
I get "permission denied" when trying to push |
mholt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently does not work because it requires caddyserver/zerossl#1 to be merged first. That dependency forced this module to upgrade its minimum Go version. That is not needed, and it's causing pains due to mis-synchronization with other parts of Caddy ecosystem. Once caddyserver/zerossl#1 is merged, the dependency here can be updated to use the next patch release of the zerossl package, then do
go mod tidyand set this PR to be ready.Depends on caddyserver/zerossl#1