Move looking up info for HTTP validation to warn level
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. I've seen these in the wild on the Caddy forums on occasion, and I agree they're not errors, they should be warnings. |
mholt
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
looking up info for HTTP {challenge,validation}from an error to a warning level.The reasoning for this is as follows: we see with our certmagic deploy that the
.well-known/acme-challenge/xxxpaths are automatically checked by old issuers that still think they are managing the domain. These acme-challenge paths are then checked by certmagic to solve the challenge, but as it's an unknown challenge token, this fails.It's still a relevant message to log, although not at the error level, IMHO.
Fixes #268