Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance for ACL #113

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Improve performance for ACL #113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43c3ee2
Improve performance for ACL
Mygod Jan 17, 2024
ee1cbce
Merge branch 'master' into hostacl
gaby Feb 13, 2024
706e39f
Merge branch 'master' into hostacl
gaby Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions forwardproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,18 @@ func (h Handler) dialContextCheckACL(ctx context.Context, network, hostPort stri
fmt.Errorf("port %s is not allowed", port))
}

match:
for _, rule := range h.aclRules {
if _, ok := rule.(*aclDomainRule); ok {
switch rule.tryMatch(nil, host) {
case aclDecisionDeny:
return nil, caddyhttp.Error(http.StatusForbidden, fmt.Errorf("disallowed host %s", host))
case aclDecisionAllow:
break match
}
}
}

// in case IP was provided, net.LookupIP will simply return it
IPs, err := net.LookupIP(host)
if err != nil {
Expand Down
Loading