Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lendingarsidur texts #153

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Lendingarsidur texts #153

merged 7 commits into from
Sep 13, 2024

Conversation

17luke
Copy link
Contributor

@17luke 17luke commented Sep 10, 2024

@thdg Can you review? These are the changes requested by Anna and Bjarni.

@SmariF89
Copy link
Collaborator

Did some code review. Please address the prettier issues as well.

@17luke
Copy link
Contributor Author

17luke commented Sep 11, 2024

Thanks! I've made all those changes except the prettier formatting. Prettier format check is only failing on some other files in the repo that seem to be a few months old. I'll fix them in a separate PR.

Excerpt from Prettier format check log:

[warn] src/components/contribute/setup/contribute.tsx
[warn] src/components/contribute/setup/demographic-form.tsx
[warn] src/pages/api/contribute/upload.ts
[warn] src/pages/api/stats/user-l2.ts
[warn] src/server/database/sentences.ts
[warn] src/services/contribute-api.ts
[warn] src/services/stats-api.ts
[warn] src/store/user/reducer.ts
[warn] src/utilities/subpage-helper.ts

@17luke
Copy link
Contributor Author

17luke commented Sep 11, 2024

Separate PR for prettier format check:
#155

@17luke
Copy link
Contributor Author

17luke commented Sep 11, 2024

Think all is resolved now

@thdg thdg merged commit 164c19c into cadia-lvl:master Sep 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants