Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PNG2C rewrite in Golang #91

Merged
merged 27 commits into from
Dec 10, 2023
Merged

[WIP] PNG2C rewrite in Golang #91

merged 27 commits into from
Dec 10, 2023

Conversation

spookbench
Copy link
Collaborator

@spookbench spookbench commented Nov 26, 2023 •
edited by cahirwpz
Loading

Pros:

  • Much faster
  • Go templates are more readable and easier to maintain
  • Only using stdlib

Cons:

  • More verbose code (no onliner hacks like in Pyhon)
  • No more PIL library

To do:

  • Fix tree' effect palettes (see Discord discussion)
  • Add grayscale pixmap support
  • Remove png2c.py when done?

@cahirwpz cahirwpz merged commit 3f1ed8f into master Dec 10, 2023
2 checks passed
@cahirwpz cahirwpz deleted the png2c-rewrite branch December 10, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spookbench @cahirwpz