Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache apt packages #7978

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Cache apt packages #7978

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c9984
Cache apt packages
ADmad Jan 4, 2025
7655449
Match apt cache key with OS version
ADmad Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
strategy:
matrix:
doc-type: ['HTML', 'EPUB', 'PDF']
Expand All @@ -33,10 +33,10 @@ jobs:
python -m pip install --upgrade pip
pip install -r requirements.txt

- name: Install packages
run: |
sudo apt update
sudo apt install texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-lang-all
- uses: awalsh128/cache-apt-pkgs-action@v1
with:
packages: texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended texlive-lang-all
version: 1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need execute_install_scripts: true ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install seemed to worked fine without it hence I didn't add it. These packages probably don't have any post install scripts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version be ubuntu-24.04 instead of 1.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a user defined value. Can be anything you want, so I just used what's shown in their docs.

Copy link
Member

@othercorey othercorey Jan 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm saying it's tied to this CI, right, so we want it to change on version change? I doubt we're updating ubuntu any time soon - not sure what happens when it needs to install newer versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the cache version to match the OS


- name: Build Docs
run: |
Expand Down
Loading