Add service account to support deploying from CI/CD #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasmcnulty
force-pushed
the
registry-secret
branch
from
c85e823
to
040faf5
Compare
tobiasmcnulty
force-pushed
the
service-account
branch
from
a0c9d4c
to
cb40035
Compare
tobiasmcnulty
force-pushed
the
registry-secret
branch
from
040faf5
to
69c431f
Compare
tobiasmcnulty
force-pushed
the
service-account
branch
3 times, most recently
from
2a9bacf
to
f12d8e1
Compare
tobiasmcnulty
changed the title
tobiasmcnulty
force-pushed
the
service-account
branch
from
78f9647
to
56aa4ee
Compare
tobiasmcnulty
force-pushed
the
registry-secret
branch
from
e42500e
to
c2eb92c
Compare
tobiasmcnulty
force-pushed
the
service-account
branch
from
56aa4ee
to
b45bf05
Compare
tobiasmcnulty
force-pushed
the
service-account
branch
from
b45bf05
to
501d716
Compare
copelco
approved these changes
Feb 5, 2020
|
|
||
| - name: Create/update templates in Kubernetes | ||
| k8s: | ||
| api_key: "{{ k8s_auth_api_key }}" |
There was a problem hiding this comment.
Should we support a path that doesn't require a deploy account? One idea would be to use the default(omit) pattern here and only perform the above deploy-account tasks or call out to another tasks file if k8s_auth_host is defined. I also see the value in always using the deploy account, so just an idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7 which should be merged first.
The service/role definitions are heavily based on: https://www.digitalocean.com/community/tutorials/how-to-automate-deployments-to-digitalocean-kubernetes-with-circleci
This seems to work but does complicate things a little for normal deploys. Is this a useful feature to have and if so are there any ways we could simplify things?
To do:
masterbefore merging