Home, Agency Index: Use new EN/ES copy with 1 new agency variable #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
machikoyasuda
commented
Jul 7, 2023
machikoyasuda
commented
Jul 7, 2023
| @@ -325,6 +325,12 @@ def load_data(app, *args, **kwargs): | |||
| jws_signing_alg=os.environ.get("MST_AGENCY_JWS_SIGNING_ALG", "RS256"), | |||
| payment_processor=mst_payment_processor, | |||
| eligibility_index_intro=_("eligibility.pages.index.p[0].mst"), | |||
| transit_option=_("agency.variables.mst.transit_option"), | |||
There was a problem hiding this comment.
@angela-tran @thekaveman Also open to suggestions on how to name these msgIds: I just made this up _("agency.variables.mst.transit_option"),
machikoyasuda
commented
Jul 7, 2023
Comment on lines
548
to
568
| msgid "eligibility.pages.start.login_gov.required_items[0]" | ||
| msgstr "Su tarjeta de identificación emitida por el estado" | ||
|
|
||
| msgid "eligibility.pages.start.login_gov.required_items[1]" | ||
| msgstr "Su número de Seguro Social" | ||
|
|
||
| msgid "eligibility.pages.start.login_gov.required_items[2]" | ||
| msgstr "Un número de teléfono con un plan de teléfono asociado con su nombre" | ||
|
|
||
| msgid "eligibility.pages.start.veteran.required_items[0]" | ||
| msgstr "Login.gov" | ||
|
|
||
| msgid "eligibility.pages.start.veteran.required_items[1]" | ||
| msgstr "ID.me" | ||
|
|
||
| msgid "eligibility.pages.start.veteran.required_items[2]" | ||
| msgstr "DS Logon" | ||
|
|
||
| msgid "eligibility.pages.start.veteran.required_items[3]" | ||
| msgstr "My HealtheVet" | ||
|
|
There was a problem hiding this comment.
???? Have no idea why Django did this !!!!!
There was a problem hiding this comment.
I know why now 😓 thankfully the changes in #1498 will prevent this clobbering from happening in the future by bin/makemessages.sh b/c the msgids will be in the app.
6 tasks
machikoyasuda
changed the title
thekaveman
reviewed
Jul 7, 2023
There was a problem hiding this comment.
This PR is simpler than #1498
We can merge this first and I can rebase on this, instead of the other way around.
4 tasks
machikoyasuda
force-pushed
the
feat/agency-variables
branch
from
dcd37cc
to
179e54d
Compare
machikoyasuda
force-pushed
the
feat/agency-variables
branch
from
179e54d
to
da83af5
Compare
|
@thekaveman Rebased |
thekaveman
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1386
What this PR does
TransitAgencymodel,transit_type. This field has amsgidvalues.TransitAgencyvariableWhat this PR does not do
TransitAgencyEligibilityVerifierTransitAgencytext field variables in any copy aside from the Index, Agency Index pagesNew variable on Transit Agency
transit_typeHow the variables are used in this PR
Figma
http://localhost:8000/mst
http://localhost:8000/sacrt