Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Login.gov button width on Tablet #1608

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 1, 2023

fix #1574

What is the problem anyway?

At this specific range of widths (1279px - 992px), the Login.gov button breaks into 2 lines in a way that is not part of the design.

image image

The button should only exist in 2 designs, as shown on Figma:

image

What this PR does

  • Make sure the Login.gov button only shows up in those 2 ways
  • Ensure the 2 Login.gov buttons are the correct dimensions
  • Modify the start.html so that I can adjust the columns for the start--seniors includes only, but keep the rest the same.
  • Widened the container from col-3 to col-4 to allow for the button to remain at width: 289px as the window scales down from 1279px to the maximum of 992px. Add flex-box classes and a max-width declaration so that the button stays at the proper width and also is right-aligned. This widening is a one-off for this includes with the Login.gov button only. Not to be done for anything else.

How to test

  • Get to Elig Start for Login.gov/Seniors and check the button in all possible screen widths
  • Ensure no regressions on the rest of the Elig Starts (Veterans, Agency Card)
  • Make sure button looks good in focus, hover modes

Documentation: Sign into Login.gov button specs

Desktop/Tablet

  • Width: 289px
  • Height: 41px
  • Font size: 16px
  • Space between top/bottom of the text and the edge: 12px (Add the 10px padding and 2 px border for total 12px)
image image image

Mobile

  • Width: 310px
  • Height: 72px
  • Font size: 20px
  • Space between top/bottom of the text and the edge: 12px
image image

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 1, 2023
@machikoyasuda machikoyasuda self-assigned this Aug 2, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 2, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review August 2, 2023 04:43
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 2, 2023 04:43
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Get to Elig Start for Login.gov/Seniors and check the button in all possible screen widths
✅ Ensure no regressions on the rest of the Elig Starts (Veterans, Agency Card)
✅ Make sure button looks good in focus, hover modes

@machikoyasuda machikoyasuda merged commit e155313 into dev Aug 2, 2023
@machikoyasuda machikoyasuda deleted the fix/1574-login.gov-button-tablet branch August 2, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Get started with Login.gov" button on Tablet widths
2 participants