-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agency Modal: New design #1646
Agency Modal: New design #1646
Conversation
e640121
to
386410c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thekaveman I wrote this up in the PR note up top:
There is no way to write CSS Grid or Flexbox code that can allow for logic like, "When there's 3 agencies, show them in 1 row. When there's 4 agencies, go with 2 rows of 2.", which is the design we have now: Once we get to 4 agencies, we have to change a few CSS Flexbox Bootstrap classes, and then add this CSS Grid code to the column-gap: 44px; /* and then assign gap figures for Mobile */
row-gap: 24px; /* and then assign gap figures for Mobile */
grid-template-columns: var(--card-width) var(--card-width); and change 2 classes (add: class="card-row row d-flex d-lg-grid flex-column text-start text-lg-center justify-content-center" I have it saved in my coding notes for the future :) So it's like a really small change. |
af875b3
to
1a5af00
Compare
Rebased |
Sorry! I didn't see that. |
closes #1634
closes #1601 - rem-ify all of the border-radiuses
What this PR does
modal
andmodal-info
templates into 1 template.Note: When we get the 4th agency, we'll have to edit some CSS so that only 2 agencies show up in each row. That'll just have to happen when we get there.
Spec changes
Desktop
- Image dimension changes:
148x72
- Card dimension changes: Constant static width and height of
200x178
. No longer dynamic.- Card inner spacing changes: Padding is now
16px
. Padding on Figma is wider, but 16px is the largest padding possible for SacRT name to fit.- Card outer spacing changes: Gap between buttons is
44px
Mobile
52x36
73
, Width is 100% of the modal width minus 16px padding on left and right.12px
.16px
24px
Button Close X
#323A45
on load#045B86
on hover