Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sample env and reset_db helper #1914

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix: sample env and reset_db helper #1914

merged 2 commits into from
Feb 29, 2024

Conversation

thekaveman
Copy link
Member

  • wraps the sample secret value in quotes in .env.sample because bash can choke on the spaces
  • fix an apparent syntax error in bin/reset_db.sh that was causing evaluation of the fixtures file to fail

spaces in the value can cause bash to choke when doing e.g.

   source .env
* remove additional variable FIXTURES that isn't necessary
* remove spacing in eval, causing evaluation to fail
@thekaveman thekaveman requested a review from a team as a code owner February 28, 2024 19:29
@github-actions github-actions bot added the deployment-dev [auto] Changes that will trigger a deploy if merged to dev label Feb 28, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman added the bug Something isn't working label Feb 28, 2024
@thekaveman thekaveman self-assigned this Feb 28, 2024
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@thekaveman thekaveman merged commit 4a266d6 into dev Feb 29, 2024
10 checks passed
@thekaveman thekaveman deleted the fix/env-db-reset branch February 29, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants