-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update SBMTD agency card name in user-facing text #1953
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 🙏
I noticed our documentation on manual tests says "Mobility Pass." It's not necessarily "user"-facing and is definitely not Benefits app copy, but just thought I'd mention it
@thekaveman I reviewed each instance where the new name appears in Spanish and I didn't see any areas where the change "broke" the copy. @mrose914 and I will do a final review during copy "testing" as part of the low-income pathway. |
Preview url: https://benefits-1953--cal-itp-previews.netlify.app |
@indexing and I spoke about this yesterday -- we want to separate this effort fully from the Low-income pathway to ensure it can go out unencumbered by that work and in time for SBMTD's April 4th event. @angela-tran good call about the docs -- while not explicitly user-facing, it is still public content and we don't want to introduce any confusion for anyone that might stumble across it, I have updated. I propose that after Angela reviews (and hopefully approves) this PR, we get it released ASAP, maybe even a quick release today (I can handle that). I have bumped the application version in this PR in anticipation of a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚌 💳
Closes #1952