Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: CalFresh eligibility start #1962

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Mar 15, 2024

Closes #1916

Screenshot

image

To test locally

Run ./bin/reset_db.sh in devcontainer to load in new fixtures that contain new start template for CalFresh verifier. Start the app with F5 and navigate through to the eligibility start page for CalFresh.

Copy link

github-actions bot commented Mar 15, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) migrations [auto] Review for potential model changes/needed data migrations updates front-end HTML/CSS/JavaScript and Django templates and removed tests Related to automated testing (unit, UI, integration, etc.) labels Mar 15, 2024
@angela-tran angela-tran force-pushed the feat/calfresh-eligibility-start branch from 3137f3e to 2953c50 Compare March 19, 2024 20:59
@angela-tran angela-tran force-pushed the feat/calfresh-eligibility-start branch from 2953c50 to 3a3044c Compare March 20, 2024 19:54
@angela-tran angela-tran marked this pull request as ready for review March 20, 2024 20:27
@angela-tran angela-tran requested a review from a team as a code owner March 20, 2024 20:27
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

Unrelated to this PR, but I'm thinking we may want to revisit the idea that each media item needs its own template and/or that the media item templates need to be specific to the eligibility pathway.

Really it seems like the are specific to the eligibility verifier, since all of calfresh, senior, and veteran use the exact same text to describe Login.gov.

@angela-tran
Copy link
Member Author

Unrelated to this PR, but I'm thinking we may want to revisit the idea that each media item needs its own template and/or that the media item templates need to be specific to the eligibility pathway.

Really it seems like the are specific to the eligibility verifier, since all of calfresh, senior, and veteran use the exact same text to describe Login.gov.

Agreed. It felt pretty weird that to create start--calfresh.html and the includes, I just copied the senior/veteran ones exactly.

Do you think we should go ahead and create an issue to consolidate them?

@angela-tran angela-tran merged commit 31b486c into dev Mar 21, 2024
8 checks passed
@angela-tran angela-tran deleted the feat/calfresh-eligibility-start branch March 21, 2024 00:17
@thekaveman
Copy link
Member

Do you think we should go ahead and create an issue to consolidate them?

Sure! That might be a good early task for Luis in addition to the testing stuff we were talking about earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eligibility start: Update “You selected an CalFresh Cardholder transit benefit.”
2 participants