Feat: enrollments can expire #1989
Commits on Apr 1, 2024
-
refactor(enrollment): check for existing group funding source first
this is instead of catching the 409 response code
-
feat(settings): app time zone is America/Los_Angeles
see https://docs.djangoproject.com/en/5.0/ref/settings/#std-setting-TIME_ZONE > Note that this isn’t necessarily the time zone of the server. > When USE_TZ is True, this is the default time zone that Django will use to display datetimes in templates > and to interpret datetimes entered in forms.
-
feat: implement expiration date calculation
use `django.utils.timezone` for access to the TIME_ZONE setting. the business logic is to set the expiration date as midnight in Pacific Time of the (N+1)th day, where N is the value of `expiration_days`.
-
feat: implement scenario - supports expiration, but no expiration
this is an unlikely but possible scenario
-
-
-
feat: implement helper function to indicate being within reenrollment
also add view test for this scenario
-
chore: raise error for a scenario that cannot be implemented yet
we want to remove the expiration date for the scenario of expiration is not supported and yet there is an expiration date. this functionality has not been implemented in cal-itp/littlepay, nor have we confirmed that it is possible
-
feat: implement scenario - supports expiration, not expired yet
leave view function and template for #1921 to implement
-
test: make assertion about expiry date more specific
we know that we should be using the value from session.enrollment_expiry
-
refactor(view): remove potentially misleading variables
use the specific condition that is leading to the branch of code, which namely is if the concession expiry is None or not.
-
refactor(view): remove unnecessary log statements
similar to what was done in 5666973
-
refactor(view): consolidate sending analytics event into success view
this removes the need for any helper function
