Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: use integer claims in OAuth #2116

Merged
merged 2 commits into from
May 29, 2024
Merged

Refactor: use integer claims in OAuth #2116

merged 2 commits into from
May 29, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented May 21, 2024 •
edited
Loading

Closes #2046

Steps for testing

Set Django's database authprovider fixtures to the new scopes/claims. Run bin/reset_db.sh to reset database.

Test results

  • Successfully test older adult flow locally
  • Successfully test veteran flow locally

@lalver1 lalver1 self-assigned this May 21, 2024
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed back-end Django views, sessions, middleware, models, migrations etc. labels May 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/oauth
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@lalver1 lalver1 marked this pull request as ready for review May 24, 2024 16:24
@lalver1 lalver1 requested a review from a team as a code owner May 24, 2024 16:24
@lalver1 lalver1 added the back-end Django views, sessions, middleware, models, migrations etc. label May 24, 2024
@lalver1 lalver1 marked this pull request as draft May 24, 2024 19:50
@lalver1
Copy link
Member Author

lalver1 commented May 24, 2024

Need to do the casting to int in authorize somewhere else in the code so reverting back to draft. Didn't realize this would be an issue until starting work on #2049.

@lalver1 lalver1 marked this pull request as ready for review May 29, 2024 17:43
angela-tran
angela-tran approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I also tested it out locally with the new scope / claim values

@lalver1 lalver1 merged commit dd13db0 into dev May 29, 2024
13 checks passed
@lalver1 lalver1 deleted the refactor/integer-claims branch May 29, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@lalver1 lalver1

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor claims handling for integer claims
2 participants
@lalver1 @angela-tran