-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: overview of the application logic #2139
Conversation
7e702b6
to
de38d95
Compare
Preview url: https://benefits-2139--cal-itp-previews.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 👍 I think the Entrypoint
and Key supporting files
call-outs work well to link the descriptions in the documentation with the code. The last diagram in the Enrollment section is also very useful given the different tokens used in this phase.
I only added one minor suggested change.
18a0fba
to
448c7b0
Compare
Thanks for the suggestion @lalver1, I added that in. I also added to each of the diagrams a block for the interaction with analytics, it's helpful to see when the key events are generated in each phase. |
I agree, adding the interaction with analytics made the diagrams even more useful yet they still look clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I really like the diagrams.
placeholder sections for each phase
Co-authored-by: Luis Alvergue <[email protected]>
use dots rather than arrows for ancillary requests
448c7b0
to
a9d6281
Compare
Based on some recent discussion and onboarding new team members, this page provides a high-level overview of all of the main phases through which the user is taken by the app.
Preview page: https://benefits-2139--cal-itp-previews.netlify.app/development/application-logic/