Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused merchant_id field #2212

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Remove unused merchant_id field #2212

merged 2 commits into from
Jul 10, 2024

Conversation

machikoyasuda
Copy link
Member

closes #2188

Acceptance Criteria

  • TransitAgency no longer has the field merchant_id

What this PR does

  • Adds migration to remove field
  • Removes field from database and test fixtures

@machikoyasuda machikoyasuda requested a review from a team as a code owner July 10, 2024 23:33
@machikoyasuda machikoyasuda self-assigned this Jul 10, 2024
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) migrations [auto] Review for potential model changes/needed data migrations updates deployment-dev [auto] Changes that will trigger a deploy if merged to dev back-end Django views, sessions, middleware, models, migrations etc. labels Jul 10, 2024
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/core
  models.py
Project Total  

This report was generated by python-coverage-comment-action

thekaveman
thekaveman approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🧹

@machikoyasuda machikoyasuda merged commit 650537a into main Jul 10, 2024
20 checks passed
@machikoyasuda machikoyasuda deleted the feat/2188-merchant_id branch July 10, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused merchant_id field from TransitAgency model
2 participants
@machikoyasuda @thekaveman