Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2445
#2445 revealed that in production, the
frame-src
directive only includesgoogle.com
and therefore blocks the transit processor iframe.This is because in
settings.py
, the logic was to throw away the originally assigned value ofCSP_FRAME_SRC
and instead use whatever is inenv_frame_src
.benefits/benefits/settings.py
Lines 310 to 315 in 8cce5ad
This logic was fine when the originally assigned value was
'none'
since the directive only allows'none'
or a space separated list of values, but in a23b51e2, we changed it to be*.littlepay.com
since we know we will always need to allow that as an iframe source.This PR fixes it so we add to
CSP_FRAME_SRC
instead of re-assigning it.