Fix: OAuth exception is not overwritten #2690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaimsProvider (oauth_client.authorize_redirect throws an exception) is not overwritten and is the one that gets bubbled further.
github-actions
bot
added
back-end
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
thekaveman
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Normally I would say we should add a test for this.
But since we'll be deleting most of this code as part of #2679, this is fine 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2643
This PR makes a change so that the original exception associated with a misconfigured
ClaimsProvider(such as an invalidauthority) is not overwritten and is the one that gets bubbled further.Reviewing
Use the
local_fixtures.jsonfile to populate your database since these fixtures have invalid values forClaimsProvider.authority. Run through the Older Adult flow and notice thatresultin Line 71 will not be created (the exception is404 Client Error: Not Found for url: https://example.com/.well-known/openid-configuration) and thus is stillNone. Note that this more specific exception is bubbled further instead ofauthorize_redirect returned Nonewhich was the original behavior.