Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page metadata should be specific to the page #254

Closed
5 tasks
thekaveman opened this issue Aug 22, 2023 · 3 comments · Fixed by #255
Closed
5 tasks

Page metadata should be specific to the page #254

thekaveman opened this issue Aug 22, 2023 · 3 comments · Fixed by #255
Assignees
Labels
bug Something isn't working

Comments

@thekaveman
Copy link
Member

thekaveman commented Aug 22, 2023

Right now we hardcode the <meta> tags to the site variables, e.g. site.title and site.description.

This means when links unfurl in e.g. social media or Slack, we always get the default site details instead of the specifics for the link itself (e.g. a Press Release).

All metadata should be specific to the page in question, and only fallback to the site configuration when page-level config is unavailable.

Todo

  • Confirm default page title (browser tabs, link unfurls) for homepage: Cal-ITP: California Integrated Travel Project
  • Confirm default page description (link unfurls) for homepage: A state government initiative, Cal-ITP is making riding by rail and bus simpler and more cost-effective—for California transit providers and riders.
  • Figure out page title (browser tabs, link unfurls) format for /press, /press/<release>, and /resources
  • Figure out description (link unfurls) for /press and /resources
  • Confirm using press.intro for /press/<release> description (link unfurls)
@thekaveman thekaveman added the bug Something isn't working label Aug 22, 2023
@mrose914
Copy link

@thekaveman I'm looking at how https://cdt.org is doing page titles and think the pattern makes sense:

For home: Show Cal-ITP: California Integrated Travel Project and then below > "Home"

Screen Shot 2023-08-22 at 10 39 43 AM

For "Press" or "Resources": Show Cal-ITP: California Integrated Travel Project and then below > "Press" or "Resources"
Screen Shot 2023-08-22 at 10 40 34 AM

For a specific press or resource: Show Cal-ITP: California Integrated Travel Project and then below > "[specific press or resource title]"
Screen Shot 2023-08-22 at 10 41 20 AM

So show Cal-ITP: California Integrated Travel Project on the top line and then either the page title or the article / resource title (if an article or resource title exists)

@thekaveman
Copy link
Member Author

Thanks @mrose914 super helpful examples! Will have a PR for your review today.

@thekaveman thekaveman self-assigned this Aug 22, 2023
@thekaveman thekaveman moved this from Todo to In Progress in Digital Services Aug 22, 2023
@mrose914
Copy link

Looks good to me @thekaveman - thank you! Big improvement 😎

@github-project-automation github-project-automation bot moved this from In Progress to Done in Digital Services Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants