Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: page metadata #255

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Fix: page metadata #255

merged 3 commits into from
Aug 22, 2023

Conversation

thekaveman
Copy link
Member

Use individual page titles/descriptions, update og and other <meta> tags.

Closes #254

@thekaveman thekaveman requested a review from a team as a code owner August 22, 2023 19:32
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 0ebfbda
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/64e51f4fea5614000844f658
😎 Deploy Preview https://deploy-preview-255--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thekaveman thekaveman self-assigned this Aug 22, 2023
src/_includes/meta.html Show resolved Hide resolved
src/_includes/meta.html Show resolved Hide resolved
@thekaveman thekaveman force-pushed the fix/metadata branch 2 times, most recently from 317035f to 333f3f3 Compare August 22, 2023 20:29
@thekaveman
Copy link
Member Author

@angela-tran @machikoyasuda I think Slack has a cached version of the site or something, because the metatags on the preview show the description correctly:

image

<meta name="description" content="The California Integrated Travel Project (Cal-ITP) today announced significant progress in implementing the Operational Data Standard (ODS) for transit agencies. In a major milestone for the project, the first vendor-to-vendor integrations powered by ODS have been officially launched. Five companies—EQUANS, Remix (owned by Via), Schedule Masters, Swiftly, and GIRO—now are capable of reading or writing ODS feeds in their software offerings.">

@machikoyasuda
Copy link
Member

image image Using this tool: https://socialsharepreview.com/?url=https://deploy-preview-255--cal-itp-website.netlify.app/press/cal-itp-partners-celebrate-major-milestone-implementation-ods image

This site says there should be og:description and og:title for LinkedIn.

image

@machikoyasuda
Copy link
Member

This one has a Discord link tester! https://www.opengraph.xyz/url/https%3A%2F%2Fdeploy-preview-255--cal-itp-website.netlify.app%2Fpress%2Fcal-itp-partners-celebrate-major-milestone-implementation-ods

Maybe we don't need og:description and og:title cos it looks like it's only for Facebook, which I don't think we care as much about.

@thekaveman
Copy link
Member Author

Nice resource @machikoyasuda thanks!

@thekaveman
Copy link
Member Author

@machikoyasuda How much do you think we care about those length limitations / suggestions?

@machikoyasuda
Copy link
Member

@thekaveman I think it's fine if to ignore for now. Slack shows the whole thing.

@machikoyasuda
Copy link
Member

@thekaveman The character limit is more of a thing for Google results, Twitter and other social share boxes that are contrained by space.
image

@thekaveman thekaveman merged commit 69e4cca into main Aug 22, 2023
4 checks passed
@thekaveman thekaveman deleted the fix/metadata branch August 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page metadata should be specific to the page
3 participants