Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add press release "Four Northern California..." #246

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

angela-tran
Copy link
Member

Closes #245

@angela-tran angela-tran self-assigned this Aug 18, 2023
@angela-tran angela-tran requested a review from a team as a code owner August 18, 2023 17:13
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 0c7a932
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/64dfa8291ee5210008443d2e
😎 Deploy Preview https://deploy-preview-246--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@angela-tran angela-tran marked this pull request as draft August 18, 2023 17:17
@angela-tran
Copy link
Member Author

angela-tran commented Aug 18, 2023

Fixed an issue where the post's datetime was in the future, so the page wasn't showing up

@angela-tran angela-tran marked this pull request as ready for review August 18, 2023 17:20
@esquared415
Copy link

@angela-tran I got an alert on this and wasn't sure what you meant here (today is 8/18/23 ... did I goof a date somewhere? thanks for helping me learn!).

@angela-tran
Copy link
Member Author

@angela-tran I got an alert on this and wasn't sure what you meant here (today is 8/18/23 ... did I goof a date somewhere? thanks for helping me learn!).

@esquared415 Oh, no the date in your source document is fine. The incorrect datetime was entirely on my end and has been fixed - I wrote that comment above just for my future self and other developers working on the site.

Here's a direct link to the press release on the preview site: https://deploy-preview-246--cal-itp-website.netlify.app/press/four-northern-california-transit-agencies-join-forces-to-buy-contactless-open-loop-fare-payment-systems-off-of-californias-purchasing-agreements

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's wait until @esquared415 approves the preview.

Homepage

image

Press Page

With the filter pill selected

image

Copy link

@esquared415 esquared415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela-tran @thekaveman This looks sooo good as a webpage instead of a standalone PDF—I love it! Real website content!! 📰 🥳

One Q for @mrose914 (but nothing that should hold us up from publishing): While I can see "Aug 2023" under the headline on the "Press" page, I don't see a date field on the press release itself—so if someone shares the direct link to the press release (bypassing the Press page), they'd have no sense of how recently this was published.

I think it would be worth having that month / year field appear somewhere on the press releases as well.

Thanks for considering, and please pub awayyyy!

@angela-tran angela-tran merged commit 4d54629 into main Aug 18, 2023
4 checks passed
@angela-tran angela-tran deleted the feat/press-release-four-ncal-transit-agencies branch August 18, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New press request
3 participants