-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Initiatives by permalink #363
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -305,6 +305,10 @@ footer a:hover { | |||
border-style: solid; | |||
} | |||
|
|||
.scroll-link { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool! Works great and the smooth scroll is nice.
One note on testing: this doesn't really work if you have already loaded the page, and then add the #pills-whatever
to the URL and hit enter, or change to #pills-whatever2
; I don't think this is a real use-case we need to be concerned about. It worked just fine if I entered the URL directly in the browser bar in a blank tab and hit enter (like what would happen if someone clicked a link).
One small request: can we swap the word pills-
for something like initiatives-
-- if these are going to be URLs that are shared, we want them to sort of make sense and not look weird 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool 😎
cc @indexing we now have direct links to the Initiatives sections on |
closes #353
How to test