Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home: Update to new dot images #374

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 24, 2024

closes #367

This PR does not change any design, just the image files and names.

Once this PR is reviewed and approved, this PR can go to production.

I am trying to break up this #364 PR into smaller chunks that can go to production.

🟢🟢 Once this PR is reviewed, this PR can be deployed to Production 🟢🟢

@machikoyasuda machikoyasuda self-assigned this Jul 24, 2024
@machikoyasuda machikoyasuda requested review from a team as code owners July 24, 2024 19:36
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit c36abdd
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66a157da06a03e00087c0a48
😎 Deploy Preview https://deploy-preview-374--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda
Copy link
Member Author

@ohmegasquared This is ready for your review: https://deploy-preview-374--cal-itp-website.netlify.app/

Please check to see if the new images look correct on both mobile and desktop.

The naming I decided on is:

home-divider-1 for the desktop images and home-divider-1-sm for the mobile images. sm means for small screens.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machikoyasuda machikoyasuda merged commit 2492f2c into main Jul 24, 2024
6 checks passed
@machikoyasuda machikoyasuda deleted the fix/367-home-dotimages branch July 24, 2024 23:09
@ohmegasquared
Copy link

looks great on web + mobile in browser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all dot images to latest
3 participants