Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Rhombus CSS classes #376

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Refactor: Rhombus CSS classes #376

merged 5 commits into from
Jul 24, 2024

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 24, 2024

closes #375

This PR is taking a single commit from #364 and teasing out what refactor can be done to the current code, to help #364 and #354 code be cleaner. There are many more custom rhombuses coming up in this current project, and the production code was using the same ID across multiple rhombuses and getting away with it because they were on different pages. This got messy.

This PR:

  • Establishes a naming convention for these classes/IDs: clipped-X and path-X, with an optional -start and -end suffix for rhombuses that appear in a row as a pair (like the Contact section and future Stats sections)
  • Changes Class and ID names - but nothing else. No design should change.
  • Ensures there are no class or ID name collisions

How to test:

  • Ensure there are no visual regressions on home page (initiatives, contact), press and resources for both desktop and mobile

🟢🟢 Once this PR is reviewed, this PR can be deployed to Production 🟢🟢

@machikoyasuda machikoyasuda requested review from a team as code owners July 24, 2024 20:45
@machikoyasuda machikoyasuda self-assigned this Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 2bf3734
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66a167d3297d8c00085c14de
😎 Deploy Preview https://deploy-preview-376--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No visual regressions observed.

@machikoyasuda machikoyasuda merged commit b72b1ab into main Jul 24, 2024
6 checks passed
@machikoyasuda machikoyasuda deleted the refactor/375-rhombus-css branch July 24, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Refactor rhombuses
2 participants