Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Home - Desktop - Dot spacing #384

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix: Home - Desktop - Dot spacing #384

merged 4 commits into from
Jul 31, 2024

Conversation

machikoyasuda
Copy link
Member

fixes #383

@machikoyasuda machikoyasuda requested a review from a team as a code owner July 30, 2024 22:57
@machikoyasuda machikoyasuda self-assigned this Jul 30, 2024
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 219d72a
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66aa88b3bb067f00072b5719
😎 Deploy Preview https://deploy-preview-384--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda
Copy link
Member Author

@ohmegasquared How does this look? https://deploy-preview-384--cal-itp-website.netlify.app/ Can you check both Desktop and Mobile?

@ohmegasquared
Copy link

Looks ready to ship on web

On mobile (sorry forgot to add in the description) there is extra space

  • first dots before: total should be 1.5rem
  • first dots after: total should be 2rem
Screenshot 2024-07-31 at 12 37 19 PM

-second dots before: can we remove 1rem from the margin?

-third dots before: update to 1rem
-third dots after: update to 2rem

@ohmegasquared
Copy link

awesome! mobile and web designs approved

@machikoyasuda
Copy link
Member Author

@thekaveman @angela-tran @lalver1 this is ready for code review! it's been reviewed + approved by Design.

@machikoyasuda machikoyasuda merged commit c20a934 into main Jul 31, 2024
5 checks passed
@machikoyasuda machikoyasuda deleted the fix/383-home-dots branch July 31, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing for dividers
3 participants