Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: A11y - Use a darker contrast-compliant gray #396

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

machikoyasuda
Copy link
Member

closes #389

Use tertiary-gray instead of seconday:

image image

I'm going to keep the secondary variable for now, in case we use it for non-text things like borders, etc.

@machikoyasuda machikoyasuda self-assigned this Aug 5, 2024
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 5, 2024 20:47
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 670479e
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/66b157a9b1372400080acb4e
😎 Deploy Preview https://deploy-preview-396--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why our code formatting has been changing lately? Is it a missing plugin? Or a new version that formats differently?

src/_includes/article.html Outdated Show resolved Hide resolved
src/_includes/article.html Outdated Show resolved Hide resolved
src/_includes/article.html Outdated Show resolved Hide resolved
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😅

Even for small PRs like this, we want to keep things as clean as possible!

@machikoyasuda machikoyasuda merged commit ed446d8 into main Aug 6, 2024
5 checks passed
@machikoyasuda machikoyasuda deleted the fix/389-fix-colors branch August 6, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y bug: Press, Resources - Grey text is too light
2 participants