Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Remove JSON file support #381

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Breaking change: Remove JSON file support #381

merged 3 commits into from
Dec 7, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 6, 2023 •
edited
Loading

closes #348

This is a breaking change.

What this PR does

  • Remove JSON import method
  • Remove JSON from Documentation
  • Remove JSON test file

@machikoyasuda machikoyasuda requested a review from a team as a code owner December 6, 2023 22:24
@machikoyasuda machikoyasuda self-assigned this Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Coverage report

Note

Coverage data for the default branch was not found.
This usually happens when the action has not run on the default
branch yet, for example right after deploying it into the workflows.

The coverage rate is 84.95%.
The branch rate is 85%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

eligibility_server/db/setup.py

100% of new lines are covered (79.09% of the complete file).

thekaveman
thekaveman approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🧹 🧹

@machikoyasuda machikoyasuda merged commit 49eb67e into dev Dec 7, 2023
8 checks passed
@machikoyasuda machikoyasuda deleted the feat/348-remove-json branch December 7, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up old JSON import code
2 participants
@machikoyasuda @thekaveman