Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move the application directory up a level #463

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jun 11, 2024

Related to:

This PR should be merged after the one in docker-python-web.

This PR also removes the explicit WORKDIR setting in the appcontainer Dockerfile, as the base image already sets the default we want.

@thekaveman thekaveman self-assigned this Jun 11, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman added the chore Chores and tasks for code cleanup, dev experience, etc. label Jun 11, 2024
@thekaveman thekaveman marked this pull request as ready for review June 12, 2024 19:05
@thekaveman thekaveman requested a review from a team as a code owner June 12, 2024 19:05
lalver1
lalver1 previously approved these changes Jun 14, 2024
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 👍 I tested by rebuilding the eligibility-server images locally (the dev container ran without a problem) and then using the eligibility_server test image for my local benefits app. I didn't test the terraform change but I'm sure it works since it looks just like the terraform change in benefits (PR 2156).

The only thing I saw is that in the compose file of benefits we use ./:/calitp/app for the volume mount and here we use .:/calitp/app/. They are both equivalent so it doesn't matter but if we wanted to make them the same we could.

removed explicit WORKDIR in appcontainer as the base image already
sets the default we want
@thekaveman
Copy link
Member Author

@lalver1:

The only thing I saw is that in the compose file of benefits we use ./:/calitp/app for the volume mount and here we use .:/calitp/app/. They are both equivalent so it doesn't matter but if we wanted to make them the same we could.

Thanks for that feedback, I fixed the mounts to be the same as in benefits and rebased.

Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thekaveman thekaveman merged commit c29fec1 into main Jul 10, 2024
7 checks passed
@thekaveman thekaveman deleted the refactor/app-dir branch July 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores and tasks for code cleanup, dev experience, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants