Settings Page #54
Open
Settings Page #54
+342
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://linear.app/bread-and-roses/issue/BRE-42/settings-page created settings cards and hardcoded dummy info
jxmoose
reviewed
Feb 24, 2025
There was a problem hiding this comment.
this shouldn't be added to git but also not sure if this file should exist in first place lol
jxmoose
reviewed
Feb 24, 2025
| <P $fontWeight="500" $color={COLORS.gray12} $align="left"> | ||
| Type of Act | ||
| </P> | ||
| <ul style={{ paddingLeft: '20px', listStyleType: 'disc' }}> |
There was a problem hiding this comment.
can you change the px to rem! overall should almost always use rem over px. https://nekocalc.com/px-to-rem-converter u can use this website but for smaller ones just divide by 16 and it should be accurate.
jxmoose
reviewed
Feb 24, 2025
| <P $fontWeight="500" $color={COLORS.gray12} $align="left"> | ||
| Genre | ||
| </P> | ||
| <ul style={{ paddingLeft: '20px', listStyleType: 'disc' }}> |
jxmoose
reviewed
Feb 24, 2025
| <P $fontWeight="500" $color={COLORS.gray12} $align="left"> | ||
| Facility Type | ||
| </P> | ||
| <ul style={{ paddingLeft: '20px', listStyleType: 'disc' }}> |
jxmoose
reviewed
Feb 24, 2025
| <P $fontWeight="500" $color={COLORS.gray12} $align="left"> | ||
| Location Preferences | ||
| </P> | ||
| <ul style={{ paddingLeft: '20px', listStyleType: 'disc' }}> |
jxmoose
reviewed
Feb 24, 2025
| <P $fontWeight="500" $color={COLORS.gray12} $align="left"> | ||
| Preferred Audience | ||
| </P> | ||
| <ul style={{ paddingLeft: '20px', listStyleType: 'disc' }}> |
jxmoose
reviewed
Feb 24, 2025
| @@ -44,21 +44,24 @@ export const Content = styled.main` | |||
| export const SubHeader = styled.main` | |||
| display: flex; | |||
| flex-direction: column; | |||
| gap: 4px; | |||
| gap: 24px; | |||
jxmoose
reviewed
Feb 24, 2025
| justify-content: start; | ||
| margin-bottom: 0.25rem; | ||
| `; | ||
|
|
||
| export const SettingDetail = styled.main` | ||
| gap: 4px; |
jxmoose
requested changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/bread-and-roses/issue/BRE-42/settings-page
created settings cards and hardcoded dummy info
🍞 What's new in this PR
🥐 Description
🥖 Screenshots
🥪 How to review
🥧 Next steps
🥞 Relevant links
🥨 Online sources
🥯 Related PRs
CC: @jxmoose