Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Calcom UI deployments #10047

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix: Calcom UI deployments #10047

merged 2 commits into from
Jul 10, 2023

Conversation

zomars
Copy link
Member

@zomars zomars commented Jul 10, 2023

What does this PR do?

It was a syntax error all along.

Before fix:

image

After fix:

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

On the apps/storybook directory, run yarn build

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:18pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:18pm
cal-staging 🔄 Building (Inspect) Mar 19, 2024 2:18pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
dev ⬜️ Ignored (Inspect) Mar 19, 2024 2:18pm
ui ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 2:18pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Jul 10, 2023
zomars
zomars commented Jul 10, 2023
View reviewed changes
packages/ui/components/TokenHandler/tokenhandler.stories.mdx
@@ -3,6 +3,7 @@ import { Examples, Example, Note, Title,CustomArgsTable } from '@calcom/storyboo
import TokenHandler from './TokenHandler'

<Meta title="UI/TokenHandler" component={TokenHandler} />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the culprit

@zomars zomars requested review from a team July 10, 2023 19:32
@sean-brydon sean-brydon linked an issue Jul 10, 2023 that may be closed by this pull request
[CAL-2110] Fix storybook build #9958
Closed
sean-brydon
sean-brydon approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God damn mdx

@zomars zomars changed the title Fix: Calcom UI deployments fix: Calcom UI deployments Jul 10, 2023
@zomars zomars enabled auto-merge (squash) July 10, 2023 19:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added the ci area: CI, DX, pipeline, github actions label Jul 10, 2023
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Jul 10, 2023
@zomars zomars merged commit cf57be2 into main Jul 10, 2023
@zomars zomars deleted the fixes/calcom-ui-build branch July 10, 2023 19:52
@sean-brydon sean-brydon mentioned this pull request Jul 11, 2023
Closed
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@zomars @fritterhoff
fix: Calcom UI deployments (calcom#10047)
8c0c79c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@sean-brydon sean-brydon sean-brydon approved these changes

Assignees
No one assigned
Labels
ci area: CI, DX, pipeline, github actions core area: core, team members only Low priority Created by Linear-GitHub Sync
Projects
No open projects
Reviewing PRs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-2110] Fix storybook build
3 participants
@zomars @PeerRich @sean-brydon