-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hide button text when loaders appears #19140
Conversation
@gaurab-khanal is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/06/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (02/06/25)1 label was added to this PR based on Keith Williams's automation. |
There might be need for project-wide changes if buttons' loading state rendering behaviour needs to be modified. |
color="secondary" | ||
disabled={installed || !!dependency} | ||
type="button" | ||
loading={isInstalling || buttonProps?.loading} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please leave a loom video for the same
It is fixed in our V3 Ui release |
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This can be testing by creating a new account and onboarding the user. You can visually see the changes once you compare it with the video provided in the issue #19127