fix slice + download

callmephilip · Jun 1, 2024 · dde3241 · dde3241
1 parent 444ab3d
commit dde3241
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/cypress/e2e/sample-project.cy.ts b/cypress/e2e/sample-project.cy.ts
@@ -4,4 +4,11 @@ describe("sample project", () => {
     cy.dcy("load-sample").click();
     cy.dcy("application-waveform").should("exist");
   });
+
+  it("supports downloads", () => {
+    cy.visit("/");
+    cy.dcy("load-sample").click();
+    cy.dcy("application-waveform").should("exist");
+    cy.get("[data-role=download-slice-button]").first().click();
+  });
 });
diff --git a/src/components/Slices.tsx b/src/components/Slices.tsx
@@ -98,6 +98,7 @@ export const Slices = () => {
                 <span className="sr-only">Delete</span>
               </Button>
               <Button
+                data-role="download-slice-button"
                 onClick={(e) => {
                   e.stopPropagation();
                   sliceAudioToFile(slice);

diff --git a/src/context/AppState.tsx b/src/context/AppState.tsx
@@ -109,13 +109,13 @@ export const AppStateProvider = ({
         },
         async sliceAudioToFile(slice) {
           if (source!.filename) {
-            const slice = await ffmpeg.sliceAudio({
+            const s = await ffmpeg.sliceAudio({
               inputFilename: source!.filename,
               start: slice.start,
               end: slice.end,
               outputFilename: `${new Date().getTime()}.mp3`,
             });
-            await ffmpeg.downloadFile(slice, "audio/mp3");
+            await ffmpeg.downloadFile(s, "audio/mp3");
           }
         },
         async loadSampleProject() {