Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better gihub actions #9

Merged
merged 85 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
2252137
fix(): fix eslint command
Dawqss Sep 27, 2024
48e1e61
feat(): new pipeline action with chaining //fastlane is only placehol…
Dawqss Sep 27, 2024
058c091
feat(): use yarn instead of npm in pipeline
Dawqss Sep 27, 2024
f560593
feat(): bump action versions
Dawqss Sep 27, 2024
7040a76
chore(): product bundle identifier
Dawqss Sep 27, 2024
2c37f4f
feat(): build-ios job with fastlane try #1
Dawqss Sep 27, 2024
28e6d6c
feat(): change ruby version to 3.2.3
Dawqss Sep 27, 2024
fc76d25
feat(): change ruby version to 3.3, change bundle version to 2.4.22
Dawqss Sep 27, 2024
b4d20bf
feat(): try to delete Gemfile.lock because fastlane cannot install on…
Dawqss Sep 27, 2024
4ff94b6
feat(): fix echo to unexisting file AuthKey
Dawqss Sep 27, 2024
41ca266
fix(): bad file name for echo
Dawqss Sep 27, 2024
e5a7a5a
chore(): check why pipeline doesnt see file
Dawqss Sep 27, 2024
68e6282
chore(): fix paths
Dawqss Sep 27, 2024
f95849a
chore(): fix paths
Dawqss Sep 27, 2024
90e131b
chore(): fix paths
Dawqss Sep 27, 2024
b500f67
chore(): fix paths
Dawqss Sep 27, 2024
e6954c5
chore(): new secrets names + envs
Dawqss Sep 27, 2024
98050b3
chore(): new secrets names + envs
Dawqss Sep 27, 2024
8c04212
chore(): pass secrets to github env
Dawqss Sep 27, 2024
30f020b
chore(): new env secrets name
Dawqss Sep 27, 2024
8c03495
chore(): another way of passing params
Dawqss Sep 27, 2024
0ed39fa
chore(): pass secrets to github env
Dawqss Sep 27, 2024
5225003
chore(): fastlane doesnt use params.. it uses options
Dawqss Sep 27, 2024
8995991
chore(): add |options| to fastlane
Dawqss Sep 27, 2024
32e76bd
chore(): revert to old ways
Dawqss Sep 27, 2024
c7a4198
chore(): pass secrets to github env
Dawqss Sep 27, 2024
3f84886
chore(): pass secrets to github env
Dawqss Sep 27, 2024
c3bfbe7
chore(): add cert action
Dawqss Sep 27, 2024
ff7d303
chore(): typo in scheme name
Dawqss Sep 27, 2024
b41ab1f
chore(): Release.xcscheme
Dawqss Sep 27, 2024
fd03a42
chore(): gym release
Dawqss Sep 27, 2024
a37d828
chore(): gym release
Dawqss Sep 27, 2024
6a4dd01
chore(): i dont know anymore
Dawqss Sep 27, 2024
7ad37b5
chore(): i dont know anymoreeee
Dawqss Sep 28, 2024
4360b79
chore(): change scheme
Dawqss Sep 28, 2024
1d17359
chore(): add Matchfile
Dawqss Sep 28, 2024
4276824
chore(): lets try new fastlane
Dawqss Sep 28, 2024
d08ca40
chore(): try echo
Dawqss Sep 28, 2024
f284b39
chore(): try echo()
Dawqss Sep 28, 2024
37e06ef
chore(): try puts instead of echo
Dawqss Sep 28, 2024
2456ef5
chore(): new variable check
Dawqss Sep 28, 2024
dbad841
chore(): add opt_out_usage
Dawqss Sep 28, 2024
a878664
chore(): pass envs by scripts
Dawqss Sep 28, 2024
3baab08
chore(): set envs
Dawqss Sep 28, 2024
4704aa4
chore(): delete fastlane api key set job
Dawqss Sep 28, 2024
7ce2263
chore(): check variables
Dawqss Sep 28, 2024
a6078ab
chore(): back to fastlane api key
Dawqss Sep 28, 2024
6b5ed04
chore(): back to fastlane api key
Dawqss Sep 28, 2024
e3c238b
chore(): back to fastlane api key
Dawqss Sep 28, 2024
3aae4cf
chore(): key is not base64
Dawqss Sep 28, 2024
03e8286
chore(): add cocoapods to gem
Dawqss Sep 28, 2024
e5d087f
chore(): add pod install without cocoapods
Dawqss Sep 28, 2024
6161104
chore(): delete install pods from ci add it to fastlane
Dawqss Sep 28, 2024
61b55f1
chore(): change Matchfile git_url to http instead of ssh
Dawqss Sep 28, 2024
1030e37
chore(): delete redundant workspace
Dawqss Sep 28, 2024
9301fda
chore(): typo adhoc -> ad-hoc
Dawqss Sep 28, 2024
faa1aaf
chore(): typo adhoc -> ad-hoc
Dawqss Sep 28, 2024
a2d1d49
chore(): typo ad-hoc -> adhoc
Dawqss Sep 28, 2024
52ffd22
chore(): try another way of provision profile
Dawqss Sep 28, 2024
70f7ab6
chore(): back to base setup
Dawqss Sep 28, 2024
f6bfced
chore(): better provision?
Dawqss Sep 28, 2024
3e2aeba
chore(): skip codesigning
Dawqss Sep 28, 2024
3c06193
chore(): dont skip codesigning
Dawqss Sep 28, 2024
01bf12e
chore(): update .gitignore
Dawqss Oct 17, 2024
4e94239
feat(): new fastlane setup, use more fastlane included features, almo…
Dawqss Oct 17, 2024
974cb1b
chore(): add comments to fastlane
Dawqss Oct 17, 2024
b7bdb44
feat(): fastlane CI on local machine with .env works | we need to upg…
Dawqss Oct 17, 2024
55d3b9d
feat(): setup github actions for new CI deploy // test
Dawqss Oct 21, 2024
6e657c2
chore(): Gemfile fastlane version update
Dawqss Oct 21, 2024
20e0dff
chore(): Gemfile update
Dawqss Oct 21, 2024
7a62fa2
feat(): update fastlane with correct token path
Dawqss Oct 22, 2024
5172ae4
feat(): update fastlane with correct token path
Dawqss Oct 22, 2024
ad00ad2
chore(): comment unused now github workflow
Dawqss Oct 22, 2024
9334e76
chore(): change env name in ci-pipeline.yml
Dawqss Oct 22, 2024
9244053
chore(): update rest of sync_code_signing
Dawqss Oct 22, 2024
fd8b89f
chore(): add install pods step
Dawqss Oct 22, 2024
b288671
feat(): add increment_build_number step
Dawqss Oct 22, 2024
02c1a6a
feat(): check composite actions for ci
Dawqss Oct 22, 2024
0681de4
feat(): check composite actions for ci
Dawqss Oct 22, 2024
3e2ffd1
feat(): check composite actions for ci / checkout_code
Dawqss Oct 22, 2024
e166970
feat(): check composite actions for ci
Dawqss Oct 22, 2024
574ed93
feat(): check composite actions for ci
Dawqss Oct 22, 2024
a3ffe50
feat(): uncomment check-build-deploy-to-test-users.yml
Dawqss Oct 22, 2024
a552048
feat(): add if: github.event.pull_request.merged == true to action
Dawqss Oct 22, 2024
dc70277
feat(): run ci action only on closed PR's
Dawqss Oct 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: 'Setup Node and Install Dependencies'
description: 'Setup Node.js and install dependencies'
runs:
using: 'composite'
steps:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '22'

- name: Cache Node.js modules
uses: actions/cache@v3
with:
path: |
~/.yarn
~/.cache
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

- name: Install dependencies
shell: bash
run: yarn install --frozen-lockfile
56 changes: 0 additions & 56 deletions .github/workflows/build.yml

This file was deleted.

63 changes: 63 additions & 0 deletions .github/workflows/check-build-deploy-to-test-users.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: CI Pipeline

on:
pull_request:
branches:
- master
types:
- closed

jobs:
tsc:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Node and Install Dependencies
uses: ./.github/actions/setup-node
- name: Run TypeScript compiler
run: yarn run tsc
lint:
runs-on: ubuntu-latest
needs: tsc
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Node and Install Dependencies
uses: ./.github/actions/setup-node
- name: Run Linting
run: yarn run lint
build-ios:
runs-on: macos-latest
needs: [tsc, lint]
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3.0'
- name: Setup Node and Install Dependencies
uses: ./.github/actions/setup-node
- name: Install Fastlane
run: |
cd ios
rm -rf Gemfile.lock
gem install bundler -v 2.4.22
bundle install
- name: Install Pods
run: |
cd ios
pod install
- name: Run Fastlane Lane
run: |
cd ios
bundle exec fastlane certificates && bundle exec fastlane deploy
env:
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }}
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
APP_STORE_CONNECT_API_KEY_KEY: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY }}
GIT_AUTHORIZATION: ${{ secrets.GIT_AUTHORIZATION }}
33 changes: 33 additions & 0 deletions .github/workflows/ci-pipeline.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: CI Pipeline

on:
pull_request:
branches:
- master

jobs:
tsc:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Node and Install Dependencies
uses: ./.github/actions/setup-node
- name: Run TypeScript compiler
run: yarn run tsc
lint:
runs-on: ubuntu-latest
needs: tsc
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Node and Install Dependencies
uses: ./.github/actions/setup-node
- name: Run Linting
run: yarn run lint
build:
runs-on: ubuntu-latest
needs: [tsc, lint]
steps:
- name: Build app with fastlane
run: echo Add fastlane lane for build only without deploy step
18 changes: 0 additions & 18 deletions .github/workflows/lint-check.yml

This file was deleted.

18 changes: 0 additions & 18 deletions .github/workflows/tsc-check.yml

This file was deleted.

10 changes: 6 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ yarn-error.log
# For more information about the recommended setup visit:
# https://docs.fastlane.tools/best-practices/source-control/

**/fastlane/report.xml
**/fastlane/Preview.html
**/fastlane/screenshots
**/fastlane/test_output
ios/oldFastlane/report.xml
ios/oldFastlane/Preview.html
ios/oldFastlane/screenshots
ios/oldFastlane/test_output

ios/fastlane/.env.default

# Bundle artifact
*.jsbundle
Expand Down
34 changes: 22 additions & 12 deletions ios/CkOnboardinApp.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,16 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 5G4M55X26F;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 5G4M55X26F;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = CkOnboardinApp/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Simple Weather App";
INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.weather";
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -485,8 +491,10 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_BUNDLE_IDENTIFIER = com.dawidcompany.simpleweatherapp;
PRODUCT_NAME = CkOnboardinApp;
PROVISIONING_PROFILE_SPECIFIER = "";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore com.dawidcompany.simpleweatherapp";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
Expand All @@ -499,9 +507,15 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 5G4M55X26F;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 5G4M55X26F;
INFOPLIST_FILE = CkOnboardinApp/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Simple Weather App";
INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.weather";
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -512,8 +526,10 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_BUNDLE_IDENTIFIER = com.dawidcompany.simpleweatherapp;
PRODUCT_NAME = CkOnboardinApp;
PROVISIONING_PROFILE_SPECIFIER = "";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore com.dawidcompany.simpleweatherapp";
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
};
Expand Down Expand Up @@ -592,10 +608,7 @@
"-DFOLLY_CFG_NO_COROUTINES=1",
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
);
OTHER_LDFLAGS = (
"$(inherited)",
" ",
);
OTHER_LDFLAGS = "$(inherited) ";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
Expand Down Expand Up @@ -668,10 +681,7 @@
"-DFOLLY_CFG_NO_COROUTINES=1",
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
);
OTHER_LDFLAGS = (
"$(inherited)",
" ",
);
OTHER_LDFLAGS = "$(inherited) ";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
USE_HERMES = true;
Expand Down
1 change: 0 additions & 1 deletion ios/CkOnboardinApp/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
<true/>
<key>NSAppTransportSecurity</key>
<dict>
<!-- Do not change NSAllowsArbitraryLoads to true, or you will risk app rejection! -->
<key>NSAllowsArbitraryLoads</key>
<false/>
<key>NSAllowsLocalNetworking</key>
Expand Down
4 changes: 4 additions & 0 deletions ios/Gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
source "https://rubygems.org"

gem "fastlane", '~> 2.224.0'
gem "dotenv"
Loading
Loading