feat: use std::threads for encoding / transcoding operations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The total spikes go from 600% to 1000%. Is this indicative of more threads being actually used (like on desktop CPU usage)? Regarding js thread the difference is staggering, nice work |
Yeah, exactly! Before we had 6 threads (6x100%) now we have total of 10 (10x100%) 👍🏻 |
okwasniewski
force-pushed
the
feat/use-threads
branch
from
ba97656 to
17c5186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds usage of std::threads to offload the work from JS thread.
Before
(Notice the load on JS Thread)
After
Test plan
Run benchmarks