fix: return when user navigates to the same page #760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes when navigating between pages (using TabBar) view state was getting out of sync, to be specific the
view.animating
was being set to true when it wasn't animating. This was happening when user was pressing multiple times on the same item.Therefore, this check was met:
Which caused pager view to be stuck on the same page. This check prevents this from happening. Reported here: react-navigation/react-navigation#10425
Test Plan
Go to TabView example and click on the same tab bar item multiple times. Check that it stops on the early return.
Compatibility
Checklist
README.md