Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename setScrollEnabled to setScrollEnabledImperatively on old arch #761

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

okwasniewski
Copy link
Member

@okwasniewski okwasniewski commented Aug 28, 2023

Summary

Rename setScrollEnabled to setScrollEnabledImperatively to fix setting scroll enabled by calling a method on ViewPager ref.

Currently when calling ref.current?.setScrollEnabled(false); we get this error message:

alt text

This was left over from the new arch migration. Fixes: #750

Currently when

Test Plan

Render this button in basic example and check if it works.

<Button
                  title="Set scroll enabled imperatively"
                  onPress={() => {
                    ref.current?.setScrollEnabled(false);
                  }}
                />

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@troZee troZee merged commit a03e44e into master Aug 29, 2023
@troZee troZee deleted the fix/okwasniewski/commands branch August 29, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setScrollEnabledImperatively Method in ReactViewPagerManager is called setScrollEnabled
3 participants