chore: experiments app tweaks #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 72 72
Lines 4266 4266
Branches 631 631
=======================================
Hits 4162 4162
Misses 104 104 ☔ View full report in Codecov by Sentry. |
experiments-app/package.json
Outdated
| "react-native-safe-area-context": "4.5.0", | ||
| "react-native-screens": "~3.20.0", | ||
| "yarn": "^1.22.19" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.20.0", | ||
| "@types/react": "~18.0.14", | ||
| "@types/react-native": "0.71", |
There was a problem hiding this comment.
Is this needed? Types are included in react-native for versions >= 71 no?
mdjastrzebski
force-pushed
the
chore/experiments-app-tweaks
branch
from
cc4d85a to
90eee74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scope:
Experiments results are described here. TLDR: we should flush micro tasks after each emitted event. Macro task behavior vary, but for simplicity we should also flush these as well.
Test plan
None